[ 
https://issues.apache.org/jira/browse/JAMES-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983893#action_12983893
 ] 

Stefano Bagnara commented on JAMES-1184:
----------------------------------------

OK, applied step2 changes.
Norman: I didn't merge mailetcontainer-library to mailetcontainer-camel mainly 
because container-spring have a direct dependency to mailetcontainer-library 
and this would have moved up the container-spring module. I think it is safe to 
not have direct "function" dependencies (I mean in source classes) in the 
container-spring module, so for the moment I preferred to limit the change.

I added some color to identify api+util, libraries, "tcp services", "data-api 
implementations" and remaining functions.

I was wondering if moving to a multilevel structure would better reflect the 
layers and help users to find what they need:
---
api
   dnsservice-api
   filesystem-api
   lifecycle-api
   queue-api
   data-api
   util
libs
   core
   data-library
   dnsservice-library
   mailetcontainer-library
   protocols-library
data
   file
   jcr
   jdbc
   jpa
   queue-activemq as activemq
   queue-jms as jms
   ldap
protocols (or services)
   imapserver
   lmtpserver
   pop3server
   smtpserver
   fetchmail
others (container? better name???)
   cli
   container-spring
   dnsservice-dnsjava
   mailbox-adapter
   mailetcontainer-camel
   mailets
   osgi
-----

The reading key is:
- Most developers will not change api or libraries modules because only core 
developers need to change them.
- Most developers will be able to tweak james by just working on functions.
- If devs need special integration then they will probably have to work in the 
"data" group and tweak the specific persistence adapter or simply add a new 
custom module.
- If devs need to tweak protocols behaviours then they will work in protocols 
and maybe on external projects (james-protocols and james-imap).

I'm still thinking more about this, but I wanted to share this thought as it is 
related to code/modules organization.


> Modules consolidation
> ---------------------
>
>                 Key: JAMES-1184
>                 URL: https://issues.apache.org/jira/browse/JAMES-1184
>             Project: JAMES Server
>          Issue Type: Task
>          Components: Build System
>    Affects Versions: 3.0-M2
>            Reporter: Stefano Bagnara
>            Assignee: Stefano Bagnara
>             Fix For: 3.0-M3
>
>         Attachments: graph-server.gif
>
>
> Just opening it to keep track of the proposal to the mailing list.
> ------------
> - mail-file(3)
> - mail-jcr(1)
> - mail-jdbc(3)
> - user-jpa(4)
> - user-file(2)
> - user-jcr(2)
> - user-jdbc(4)
> - domainlist-jpa(2)
> - domainlist-xml(1)
> I only see benefits and no drawbacks in consolidating the 9 modules
> above to the following 4 modules:
>  persistence-jpa(6) = user-jpa(4)+domainlist-jpa(2)
>  persistence-file(6) = user-file(2)+mail-file(3)+domainlist-xml(1)
>  persistence-jcr(3) = user-jcr(2)+mail-jcr(1)
>  persistence-jdbc(7) = user-jdbc(4)+mail-jdbc(3)
> - mail-library(1)
> - domainlist-library(2)
> - user-library(9)
> We could consolidate them into a persistence-library module (from 3 to
> 1 module).
>  persistence-library(12) =
> mail-library(1)+domainlist-library(2)+user-library(9)
> - queue-library(2)
> - queue-jms(5)
> We could merge queue-library to queue-jms (a library module makes
> sense when we do something useful.. if it is trivial stuff it can be
> duplicated or moved to the api layer).
>  queue-jms(7) = queue-jms(5)+queue-library(2)
> -------------------------
> It seems there is agreement on the merging. We still have to decide whether 
> to name the modules "persistence-${type}" or simply "${type}" (or maybe 
> "data-${type}")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to