[
https://issues.apache.org/jira/browse/JAMES-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328602#comment-16328602
]
ASF GitHub Bot commented on JAMES-2310:
---------------------------------------
Github user chibenwa commented on the issue:
https://github.com/apache/james-project/pull/98
I opened another review here
https://github.com/linagora/james-project/pull/1239 in order to play the
Continuous Integration against your pull request.
Might we have any request, we will not hesitate to ask you.
And thanks again for contributing.
Cheers,
Benoit
> Use LineBasedFrameDecoder instead of DelimiterBasedFrameDecoder
> ---------------------------------------------------------------
>
> Key: JAMES-2310
> URL: https://issues.apache.org/jira/browse/JAMES-2310
> Project: James Server
> Issue Type: Improvement
> Components: IMAPServer, SMTPServer
> Affects Versions: 3.0.1
> Reporter: TzeKai Lee
> Priority: Major
>
> The LineBasedFrameDecoder is optimized version of DelimiterBasedFrameDecoder
> which provide some good performance gain. The DelimiterBasedFrameDecoder
> already automatically use LineBasedFrameDecoder if we use
> DelimiterBasedFrameDecoder (_but not subclass_) and with CRLF/LF as
> delimiter. However in SMTP and IMAP server we have to subclass it, therefore
> we should directly extend LineBasedFrameDecoder for the performance gain.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
