[
https://issues.apache.org/jira/browse/JAMES-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328754#comment-16328754
]
ASF GitHub Bot commented on JAMES-2310:
---------------------------------------
Github user rouazana commented on a diff in the pull request:
https://github.com/apache/james-project/pull/98#discussion_r162047764
--- Diff:
protocols/smtp/src/main/java/org/apache/james/protocols/smtp/AllButStartTlsLineChannelHandlerFactory.java
---
@@ -21,18 +21,17 @@
import org.apache.james.protocols.netty.ChannelHandlerFactory;
import org.jboss.netty.channel.ChannelHandler;
import org.jboss.netty.channel.ChannelPipeline;
-import org.jboss.netty.handler.codec.frame.Delimiters;
-public class AllButStartTlsLineDelimiterChannelHandlerFactory implements
ChannelHandlerFactory {
+public class AllButStartTlsLineChannelHandlerFactory implements
ChannelHandlerFactory {
--- End diff --
LineChannel -> LineBasedChannel?
> Use LineBasedFrameDecoder instead of DelimiterBasedFrameDecoder
> ---------------------------------------------------------------
>
> Key: JAMES-2310
> URL: https://issues.apache.org/jira/browse/JAMES-2310
> Project: James Server
> Issue Type: Improvement
> Components: IMAPServer, SMTPServer
> Affects Versions: 3.0.1
> Reporter: TzeKai Lee
> Priority: Major
>
> The LineBasedFrameDecoder is optimized version of DelimiterBasedFrameDecoder
> which provide some good performance gain. The DelimiterBasedFrameDecoder
> already automatically use LineBasedFrameDecoder if we use
> DelimiterBasedFrameDecoder (_but not subclass_) and with CRLF/LF as
> delimiter. However in SMTP and IMAP server we have to subclass it, therefore
> we should directly extend LineBasedFrameDecoder for the performance gain.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
