[ https://issues.apache.org/jira/browse/JAMES-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331624#comment-16331624 ]
ASF GitHub Bot commented on JAMES-2310: --------------------------------------- Github user chibenwa commented on the issue: https://github.com/apache/james-project/pull/98 Hi, This pull request has just been merged. Thank you again for your dedication toward the James project. If you need help, want to contribute documentation, new features, tests or bugfix, please don't hesitate to reach us. One very last thing: I don't have write access to this repository, hence I can not close this issue. Wouldn't you mind doing it for me? It would avoid me annoying the Apache INFRA team with such simple concerns. Thanks again, Cheers, Benoit > Use LineBasedFrameDecoder instead of DelimiterBasedFrameDecoder > --------------------------------------------------------------- > > Key: JAMES-2310 > URL: https://issues.apache.org/jira/browse/JAMES-2310 > Project: James Server > Issue Type: Improvement > Components: IMAPServer, SMTPServer > Affects Versions: 3.0.1 > Reporter: TzeKai Lee > Priority: Major > > The LineBasedFrameDecoder is optimized version of DelimiterBasedFrameDecoder > which provide some good performance gain. The DelimiterBasedFrameDecoder > already automatically use LineBasedFrameDecoder if we use > DelimiterBasedFrameDecoder (_but not subclass_) and with CRLF/LF as > delimiter. However in SMTP and IMAP server we have to subclass it, therefore > we should directly extend LineBasedFrameDecoder for the performance gain. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org