[ 
https://issues.apache.org/jira/browse/JAMES-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539851#comment-16539851
 ] 

ASF GitHub Bot commented on JAMES-2167:
---------------------------------------

Github user chibenwa commented on a diff in the pull request:

    https://github.com/apache/james-project/pull/126#discussion_r201638127
  
    --- Diff: 
server/queue/queue-jms/src/test/java/org/apache/james/queue/jms/JMSSerializationUtilsTest.java
 ---
    @@ -0,0 +1,119 @@
    +/****************************************************************
    + * Licensed to the Apache Software Foundation (ASF) under one   *
    + * or more contributor license agreements.  See the NOTICE file *
    + * distributed with this work for additional information        *
    + * regarding copyright ownership.  The ASF licenses this file   *
    + * to you under the Apache License, Version 2.0 (the            *
    + * "License"); you may not use this file except in compliance   *
    + * with the License.  You may obtain a copy of the License at   *
    + *                                                              *
    + *   http://www.apache.org/licenses/LICENSE-2.0                 *
    + *                                                              *
    + * Unless required by applicable law or agreed to in writing,   *
    + * software distributed under the License is distributed on an  *
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY       *
    + * KIND, either express or implied.  See the License for the    *
    + * specific language governing permissions and limitations      *
    + * under the License.                                           *
    + ****************************************************************/
    +package org.apache.james.queue.jms;
    +
    +import static org.apache.james.queue.jms.JMSSerializationUtils.deserialize;
    +import static 
org.apache.james.queue.jms.JMSSerializationUtils.hasJMSNativeSupport;
    +import static org.apache.james.queue.jms.JMSSerializationUtils.roundtrip;
    +import static 
org.apache.james.queue.jms.JMSSerializationUtils.trySerialize;
    +import static org.assertj.core.api.Assertions.assertThat;
    +import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
    +
    +import java.io.Serializable;
    +import java.util.Objects;
    +
    +import org.apache.commons.codec.binary.Base64;
    +import org.apache.commons.lang3.SerializationException;
    +import org.assertj.core.api.SoftAssertions;
    +import org.junit.jupiter.api.Test;
    +
    +class JMSSerializationUtilsTest {
    --- End diff --
    
    Are you sure?
    
    Because for me it returns `41` instead of 
`"rO0ABXNyABFqYXZhLmxhbmcuSW50ZWdlchLioKT3gYc4AgABSQAFdmFsdWV4cgAQamF2YS5sYW5nLk51bWJlcoaslR0LlOCLAgAAeHAAAAAp"`


> Serializable attributes are not preserved by enqueue/dequeue on a JMS queue
> ---------------------------------------------------------------------------
>
>                 Key: JAMES-2167
>                 URL: https://issues.apache.org/jira/browse/JAMES-2167
>             Project: James Server
>          Issue Type: Bug
>          Components: Queue
>    Affects Versions: master
>            Reporter: Tellier Benoit
>            Priority: Major
>
> A call to toString breaks convertion for generic serializable attributes. 
> The dequeued email will have only a toString version of it. We are expecting 
> the exact same value, just deserialized.
> We should ensure the value of Serializable attributes gets preserved by 
> enqueue/dequeue operations. We should add a unit test for this, and fix it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to