[ https://issues.apache.org/jira/browse/JAMES-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539858#comment-16539858 ]
ASF GitHub Bot commented on JAMES-2167: --------------------------------------- Github user nstdio commented on a diff in the pull request: https://github.com/apache/james-project/pull/126#discussion_r201639825 --- Diff: server/queue/queue-jms/src/main/java/org/apache/james/queue/jms/JMSSerializationUtils.java --- @@ -0,0 +1,109 @@ +/**************************************************************** + * Licensed to the Apache Software Foundation (ASF) under one * + * or more contributor license agreements. See the NOTICE file * + * distributed with this work for additional information * + * regarding copyright ownership. The ASF licenses this file * + * to you under the Apache License, Version 2.0 (the * + * "License"); you may not use this file except in compliance * + * with the License. You may obtain a copy of the License at * + * * + * http://www.apache.org/licenses/LICENSE-2.0 * + * * + * Unless required by applicable law or agreed to in writing, * + * software distributed under the License is distributed on an * + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * + * KIND, either express or implied. See the License for the * + * specific language governing permissions and limitations * + * under the License. * + ****************************************************************/ +package org.apache.james.queue.jms; + +import java.io.Serializable; +import java.util.Optional; + +import org.apache.commons.codec.binary.Base64; +import org.apache.commons.lang3.SerializationUtils; + +import com.github.fge.lambdas.Throwing; + +/** + * This class is similar to {@link SerializationUtils}. Unlike {@link SerializationUtils} this class operates with + * {@code String}s and not byte arrays. + * <p> + * The main advantage of this utility is that it introduces an additional operation after serialization and before + * deserialization. The operation consists in encoding/decoding the serialized/deserialized data in Base64, so that + * data can be safely transmitted over the wire. + */ +final class JMSSerializationUtils { + private JMSSerializationUtils() { + throw new AssertionError("No instances!"); + } + + /** + * Checks {@code value} is native supported by the JMS spec. + * <p> + * The following types are supported: {@code null}, {@code String}, all primitive wrappers except {@code + * Character}. + * <p> + * Note that neither {@link java.util.Map} nor {@link java.util.List} is not supported by default. + */ + static boolean hasJMSNativeSupport(Object value) { + return value == null || value instanceof String || value instanceof Boolean || + value instanceof Byte || value instanceof Short || value instanceof Integer || value instanceof Long || + value instanceof Double || value instanceof Float; + } + + /** + * The convenient method that serialize provided {@code value} if it is not supported by JMS. If JMS does support + * {@code value} type the object itself will be returned. + * + * @param value The serialization candidate. + * + * @return The serialized base64 string or {@code value} itself. + */ + static Object trySerialize(Serializable value) { + return hasJMSNativeSupport(value) ? value : serialize(value).orElse(null); --- End diff -- String and other types mentioned in `hasJMSNativeSupport` will not be serialized at all. > Serializable attributes are not preserved by enqueue/dequeue on a JMS queue > --------------------------------------------------------------------------- > > Key: JAMES-2167 > URL: https://issues.apache.org/jira/browse/JAMES-2167 > Project: James Server > Issue Type: Bug > Components: Queue > Affects Versions: master > Reporter: Tellier Benoit > Priority: Major > > A call to toString breaks convertion for generic serializable attributes. > The dequeued email will have only a toString version of it. We are expecting > the exact same value, just deserialized. > We should ensure the value of Serializable attributes gets preserved by > enqueue/dequeue operations. We should add a unit test for this, and fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org