Sent from Outlook Mobile<https://aka.ms/qtex0l>
________________________________
From: ASF GitHub Bot (JIRA) <server-dev@james.apache.org>
Sent: Thursday, July 12, 2018 3:03:00 AM
To: server-dev@james.apache.org
Subject: [jira] [Commented] (JAMES-2167) Serializable attributes are not
preserved by enqueue/dequeue on a JMS queue
[
https://issues.apache.org/jira/browse/JAMES-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540911#comment-16540911
]
ASF GitHub Bot commented on JAMES-2167:
---------------------------------------
Github user chibenwa commented on a diff in the pull request:
https://github.com/apache/james-project/pull/126#discussion_r201874918
--- Diff:
server/queue/queue-jms/src/test/java/org/apache/james/queue/jms/JMSSerializationUtilsTest.java
---
@@ -0,0 +1,106 @@
+/****************************************************************
+ * Licensed to the Apache Software Foundation (ASF) under one *
+ * or more contributor license agreements. See the NOTICE file *
+ * distributed with this work for additional information *
+ * regarding copyright ownership. The ASF licenses this file *
+ * to you under the Apache License, Version 2.0 (the *
+ * "License"); you may not use this file except in compliance *
+ * with the License. You may obtain a copy of the License at *
+ * *
+ * http://www.apache.org/licenses/LICENSE-2.0 *
+ * *
+ * Unless required by applicable law or agreed to in writing, *
+ * software distributed under the License is distributed on an *
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY *
+ * KIND, either express or implied. See the License for the *
+ * specific language governing permissions and limitations *
+ * under the License. *
+ ****************************************************************/
+package org.apache.james.queue.jms;
+
+import org.apache.commons.codec.binary.Base64;
+import org.apache.commons.lang3.SerializationException;
+import org.junit.jupiter.api.Test;
+
+import java.io.Serializable;
+import java.util.Objects;
+import java.util.Optional;
+
+import static org.apache.james.queue.jms.JMSSerializationUtils.deserialize;
+import static org.apache.james.queue.jms.JMSSerializationUtils.serialize;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
+
+class JMSSerializationUtilsTest {
+ /**
+ * Serializes and deserializes the provided object.
+ *
+ * @param obj The object that needs to be serialized.
+ * @param <T> The type of the provided object.
+ *
+ * @return The provided object.
+ */
+ private static <T extends Serializable> T roundtrip(T obj) {
+ return Optional.ofNullable(obj)
+ .map(JMSSerializationUtils::serialize)
+ .<T>map(JMSSerializationUtils::deserialize)
+ .orElseThrow(() -> new IllegalArgumentException("Cannot
serialize/deserialize: " + obj));
+ }
+
+ @Test
+ void trySerializeShouldReturnString() {
+ SerializableStringHolder value = new
SerializableStringHolder("value");
+
+ String expected =
"rO0ABXNyAE1vcmcuYXBhY2hlLmphbWVzLnF1ZXVlLmptcy5KTVNTZXJpYWxp" +
--- End diff --
We should explain what this string is. I propose to rename it
'serializedInteger' to explain how it was generated
> Serializable attributes are not preserved by enqueue/dequeue on a JMS queue
> ---------------------------------------------------------------------------
>
> Key: JAMES-2167
> URL: https://issues.apache.org/jira/browse/JAMES-2167
> Project: James Server
> Issue Type: Bug
> Components: Queue
> Affects Versions: master
> Reporter: Tellier Benoit
> Priority: Major
>
> A call to toString breaks convertion for generic serializable attributes.
> The dequeued email will have only a toString version of it. We are expecting
> the exact same value, just deserialized.
> We should ensure the value of Serializable attributes gets preserved by
> enqueue/dequeue operations. We should add a unit test for this, and fix it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
