Jini, Looks good for me!
-Dmitry On 2016-08-11 08:57, Jini Susan George wrote: > Thank you very much, Dmitry for the review. I have created a new webrev with > a launchJStack() method in BasicLauncherTest.java. The exit value is 0, > despite the error -- so that does not help. Please do take a look at the > modified webrev: > > http://cr.openjdk.java.net/~sballal/sponsorship/8163143/webrev.01/ > > Thanks, > -Jini. > >> -----Original Message----- >> From: Dmitry Samersoff >> Sent: Wednesday, August 10, 2016 1:42 PM >> To: Jini Susan George; serviceability-dev@openjdk.java.net; Lindenmaier, >> Goetz >> Subject: Re: RFR: JDK-8163143: illegal bci error with interpreted frames in >> SA due to mirror being stored in interpreted frames >> >> Jini, >> >> Code changes looks good for me. >> >> CC'in Goetz for PPC changes. >> >> >> BasicLauncherTest.java: >> >> I'm not sure we need two extra parameters to launch() just to check for >> jstack Assertion Failure. >> >> Please either create a separate launchJStack method or just check exit >> code of jhsdb jstack. >> >> -Dmitry >> >> On 2016-08-10 10:10, Jini Susan George wrote: >>> Hi all, >>> >>> >>> >>> Please do review the changes for the SA defect: >>> >>> >>> >>> https://bugs.openjdk.java.net/browse/JDK-8163143 >>> >>> >>> >>> The webrev is at: >>> >>> >>> >>> http://cr.openjdk.java.net/~sballal/sponsorship/8163143/webrev.00/ >>> >>> >>> >>> Need testing with PPC64 for this. I have implemented the changes but >>> have not tested on PPC64. >>> >>> >>> >>> Thank you, >>> >>> - Jini Susan George >>> >>> >>> >> >> >> -- >> Dmitry Samersoff >> Oracle Java development team, Saint Petersburg, Russia >> * I would love to change the world, but they won't give me the sources. -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.
