On 29/08/2016 2:29 PM, David Holmes wrote:
On 29/08/2016 2:14 PM, Jini Susan George wrote:
Thank you, Mandy. The test was throwing an NPE due to the option
“-XX:+UnlockDiagnosticVMOptions” not being used for
TestInstanceKlassSizeForInterface.java in the release build. jcmd’s
GC.class_stats requires this, and hence, parsing of the jcmd output was
resulting in an NPE.
-XX:+UnlockDiagnosticVMOptions is for controlling access to a diagnostic
VM flag. I don't see any such flags being used.
-XX:+UnlockDiagnosticVMOptions should not be controlling internal
behaviour independent of a VM flag!
While I see the check in ClassStatsDCmd::execute I see absolutely no
reason that it should be constrained this way!
This behaviour does not make sense to me.
I see it was added by:
https://bugs.openjdk.java.net/browse/JDK-6479360
but I still see no reason for it. Perhaps Ioi can enlighten us?
David
David
Regards,
Jini.
*From:*Mandy Chung
*Sent:* Saturday, August 27, 2016 7:14 AM
*To:* Jini Susan George
*Cc:* serviceability-dev@openjdk.java.net
*Subject:* Re: RFR:(S): 8164562:
serviceability/sa/TestInstanceKlassSizeForInterface.java: fails with NPE
On Aug 23, 2016, at 11:10 PM, Jini Susan George <jini.geo...@oracle.com
<mailto:jini.geo...@oracle.com>> wrote:
Hi all,
Could you please review the fix for:
Bug: https://bugs.openjdk.java.net/browse/JDK-8164562
Webrev: http://cr.openjdk.java.net/~jgeorge/8164562/webrev.00/
I took the liberty to do some module related cleanups in the test
also while fixing this issue.
The @module cleanup looks fine to
workaround https://bugs.openjdk.java.net/browse/CODETOOLS-7901761
What causes the test to throw NPE? It's unclear to me.
Mandy
