Thank you, David. -jini.
> -----Original Message----- > From: David Holmes > Sent: Tuesday, August 30, 2016 11:07 AM > To: Jini Susan George; serviceability-dev@openjdk.java.net > Subject: Re: RFR:(S): 8164562: > serviceability/sa/TestInstanceKlassSizeForInterface.java: fails with NPE > > Hi Jini, > > On 29/08/2016 5:51 PM, Jini Susan George wrote: > > Hi David, > > > > Thank you for the review. I have added a few more asserts and uploaded a > modified webrev: > > > > http://cr.openjdk.java.net/~jgeorge/8164562/webrev.01/ > > > > Please do take a relook. > > The added assertions are good. Thanks. > > The layout/indent in those tests is all over the place, but fixing all > that is out of scope I think. > > We can discuss the use of -XX:+UnlockDiagnosticVMOptions separately. > > Thanks, > David > > > Thanks, > > Jini. > > > > > >> -----Original Message----- > >> From: David Holmes > >> Sent: Monday, August 29, 2016 9:36 AM > >> To: Jini Susan George; serviceability-dev@openjdk.java.net > >> Subject: Re: RFR:(S): 8164562: > >> serviceability/sa/TestInstanceKlassSizeForInterface.java: fails with NPE > >> > >> On 24/08/2016 4:10 PM, Jini Susan George wrote: > >>> Hi all, > >>> > >>> Could you please review the fix for: > >>> > >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8164562 > >>> > >>> Webrev: http://cr.openjdk.java.net/~jgeorge/8164562/webrev.00/ > >>> > >>> I took the liberty to do some module related cleanups in the test also > >>> while fixing this issue. > >> > >> So which change fixes the actual bug? > >> > >> As far as I can see if the output of the command is not as expected we > >> return a null and that then leads to the NPE when calling > >> String.contains. Seems to me that the test should be more resilient here > >> and give a meaningful error message if the expected output is not seen. > >> > >> Thanks, > >> David > >> > >>> > >>> > >>> Thank you, > >>> > >>> - Jini Susan George > >>> > >>> > >>>
