Hi JC,
Some initial JVMTI-specific questions/comments. I was not able to apply your patch as the are many merge conflicts. Could you, please, re-base it on the latest JDK 10 sources? I think, it would make sense to introduce new optional capability, something like: can_sample_heap_allocations Do you consider this API to be used by a single agent or it is a multi-agent feature? What if one agent calls the StartHeapSampling() but another calls one of the others. The API specs needs to clarify this. I'm not sure you had a chance to carefully think on what JVMTI phases are allowed for new functions. http://cr.openjdk.java.net/~rasbold/8171119/webrev.06/src/share/vm/runtime/heapMonitoring.cpp.html I do not see the variable HeapMonitoring::_enabled is checked in the functions: HeapMonitoring::get_live_traces(), HeapMonitoring::get_garbage_traces(), HeapMonitoring::get_frequent_garbage_traces(), HeapMonitoring::release_traces() A question about a multi-agent feature from above applies here as well. Thanks, Serguei On 6/21/17 13:45, JC Beyler wrote:
|
- Re: Low-Overhead Heap Profiling JC Beyler
- Re: Low-Overhead Heap Profiling Robbin Ehn
- Re: Low-Overhead Heap Profiling serguei.spit...@oracle.com
- Re: Low-Overhead Heap Profiling Robbin Ehn
- Re: Low-Overhead Heap Profilin... JC Beyler
- Re: Low-Overhead Heap Profilin... JC Beyler
- Re: Low-Overhead Heap Pro... Robbin Ehn
- Re: Low-Overhead Heap... Robbin Ehn
- Re: Low-Overhead Heap... Robbin Ehn
- Re: Low-Overhead Heap... Thomas Schatzl
- Re: Low-Overhead Heap... serguei.spit...@oracle.com
- Re: Low-Overhead Heap... serguei.spit...@oracle.com
- Re: Low-Overhead Heap... serguei.spit...@oracle.com
- Re: Low-Overhead Heap... serguei.spit...@oracle.com
- Re: Low-Overhead Heap... Thomas Schatzl
- Re: Low-Overhead Heap... Robbin Ehn
- Re: Low-Overhead Heap... Robbin Ehn
- Re: Low-Overhead Heap... JC Beyler
- Re: Low-Overhead Heap... JC Beyler
- Re: Low-Overhead Heap... Robbin Ehn
- Re: Low-Overhead Heap... JC Beyler