Re: RFR (S): 8193258: Better usage of JDWP HEADER SIZE

Fri, 08 Dec 2017 12:20:31 -0800

Hi Christoph,

The fix looks good to me.
What tests did you run?


On 12/8/17 07:07, Langer, Christoph wrote:

Hi,

 

Here’s a proposal to clean up the usage of the JDWP header size within the source code of libjdwp.

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8193258

WebRev: http://cr.openjdk.java.net/~clanger/webrevs/8193258.0/

 

As for inStream.c, I’m wondering wether inStream_endOfInput shall be removed? It seems to be unused…


I'm inclined to remove it.
Otherwise, it must be:
  417 return (stream->left <= 0);

Thanks,
Serguei
 

Best regards

Christoph

 


Reply via email to