Re: RFR (S): 8193258: Better usage of JDWP HEADER SIZE

[Chris Plummer]

Yes, those are covered by :jdk_svc, but he should also run them first. Chris On 12/8/17 9:56 PM, serguei.spit...@oracle.com wrote: Hi Chris, Thank you, Chris for doing this. In general, it is still a good idea for Christoph to always run the com/sun/jdi tests locally. The hotspot/jtreg/serviceability/jdwp tests do not provide a complete coverage. Thanks, Serguei On 12/8/17 21:46, Chris Plummer wrote: I think I ran everything svc related. I did the following open/test/hotspot/jtreg/:hotspot_serviceability open/test/jdk/:jdk_svc Plus the closed equivalents and all our other closed svc test lists. Chris On 12/8/17 9:26 PM, serguei.spit...@oracle.com wrote: Hi Christoph, You need to run at least the jdk/com/sun/jdi tests. Thanks, Serguei On 12/8/17 13:07, Langer, Christoph wrote: Hi Serguei,   I did only run hotspot/jtreg/serviceability/jdwp, didn’t find a lot more in that area. I’m hoping/waiting for Chris’ tests then.   I agree, I will then remove inStream_endOfInput. If something like that is needed for future developments, it can easily be added again.     Best regards Christoph   From: serguei.spit...@oracle.com [mailto:serguei.spit...@oracle.com] Sent: Freitag, 8. Dezember 2017 21:12 To: Langer, Christoph <christoph.lan...@sap.com>; serviceability-dev@openjdk.java.net; Chris Plummer <chris.plum...@oracle.com> Subject: Re: RFR (S): 8193258: Better usage of JDWP HEADER SIZE   Hi Christoph, The fix looks good to me. What tests did you run? On 12/8/17 07:07, Langer, Christoph wrote: Hi,   Here’s a proposal to clean up the usage of the JDWP header size within the source code of libjdwp.   Bug: https://bugs.openjdk.java.net/browse/JDK-8193258 WebRev: http://cr.openjdk.java.net/~clanger/webrevs/8193258.0/   As for inStream.c, I’m wondering wether inStream_endOfInput shall be removed? It seems to be unused… I'm inclined to remove it. Otherwise, it must be:   417 return (stream->left <= 0); Thanks, Serguei   Best regards Christoph