Hi Egor,
Looks good to me as well, nit would be that the rest of the file does not
add a new-line for a else if:
if () {
} else if () {
}
instead of what you added:
if () {
}
else if () {
}
(Not a Reviewer)
Thanks,
Jc
On Thu, Mar 21, 2019 at 11:31 AM [email protected] <
[email protected]> wrote:
> Hi Egor,
>
> The fix looks good to me.
>
> Thank you for taking care about it!
> I've targeted this enhancement to 13.
>
> How do you test it?
> It would be safe to run all JDI tests to make sure no new timeouts are
> observed.
>
> Thanks,
> Serguei
>
>
> On 3/21/19 10:19, Egor Ushakov wrote:
> > Hi all, please review the fix
> >
> > it disables caching for types when signature is not provided as
> > described in the bug (this is one of the proposed solutions in the bug).
> >
> > https://bugs.openjdk.java.net/browse/JDK-8146986
> > http://cr.openjdk.java.net/~eushakov/8146986/webrev.00/
> >
> > Thanks!
> >
>
>
--
Thanks,
Jc
