Re: RFR: 8146986: JDI: Signature lookups for unprepared classes can take a long time

[serguei.spit...@oracle.com]

Hi Egor, Pushed. Thanks, Serguei On 3/23/19 22:41, Egor Ushakov wrote: Yes, the latest fix passed these test. Serguei, can you please sponsor the fix? On 22-Mar-19 23:25, serguei.spit...@oracle.com wrote: Hi Egor, It looks Okay to me. Just want to make sure all important JDI tests are run. There are two major JDI test suites:   jdk/com/sun/jdi and hotspot/jtreg/vmTestbase/nsk/jdi Thanks, Serguei On 3/22/19 11:51, Egor Ushakov wrote: Thanks for your comments, some jdi test were really failing :( As we switched from TreeSet to HashSet we have to explicitly set signature now. Please review the updated fix: http://cr.openjdk.java.net/~eushakov/8146986/webrev.01/ On 21-Mar-19 22:39, Jean Christophe Beyler wrote: Hi Egor, Looks good to me as well, nit would be that the rest of the file does not add a new-line for a else if: if () { } else if () { } instead of what you added: if () { } else if () { } (Not a Reviewer) Thanks, Jc On Thu, Mar 21, 2019 at 11:31 AM serguei.spit...@oracle.com <serguei.spit...@oracle.com> wrote: Hi Egor, The fix looks good to me. Thank you for taking care about it! I've targeted this enhancement to 13. How do you test it? It would be safe to run all JDI tests to make sure no new timeouts are observed. Thanks, Serguei On 3/21/19 10:19, Egor Ushakov wrote: > Hi all, please review the fix > > it disables caching for types when signature is not provided as > described in the bug (this is one of the proposed solutions in the bug). > > https://bugs.openjdk.java.net/browse/JDK-8146986 > http://cr.openjdk.java.net/~eushakov/8146986/webrev.00/ > > Thanks! > -- Thanks, Jc -- Egor Ushakov Software Developer JetBrains http://www.jetbrains.com The Drive to Develop -- Egor Ushakov Software Developer JetBrains http://www.jetbrains.com The Drive to Develop