|
Hi Egor,
It looks Okay to me.
Just want to make sure all important JDI tests are run.
There are two major JDI test suites:
jdk/com/sun/jdi and hotspot/jtreg/vmTestbase/nsk/jdi
Thanks,
Serguei
On 3/22/19 11:51, Egor Ushakov wrote:
Thanks for your comments,
some jdi test were really failing :(
As we switched from TreeSet to HashSet we have to explicitly set
signature now.
Please review the updated fix: http://cr.openjdk.java.net/~eushakov/8146986/webrev.01/
On 21-Mar-19 22:39, Jean Christophe
Beyler wrote:
Hi Egor,
Looks good to me as well, nit would be that the rest of
the file does not add a new-line for a else if:
if () {
} else if () {
}
instead of what you added:
(Not a Reviewer)
Thanks,
Jc
Hi Egor,
The fix looks good to me.
Thank you for taking care about it!
I've targeted this enhancement to 13.
How do you test it?
It would be safe to run all JDI tests to make sure no new
timeouts are
observed.
Thanks,
Serguei
On 3/21/19 10:19, Egor Ushakov wrote:
> Hi all, please review the fix
>
> it disables caching for types when signature is not
provided as
> described in the bug (this is one of the proposed
solutions in the bug).
>
> https://bugs.openjdk.java.net/browse/JDK-8146986
> http://cr.openjdk.java.net/~eushakov/8146986/webrev.00/
>
> Thanks!
>
--
--
Egor Ushakov
Software Developer
JetBrains
http://www.jetbrains.com
The Drive to Develop
|
