> Please review this change for hotspot and one test. > There is few JVMTI callback/event functions in jdk which signature doesn't > match specification. > for example: > static jvmtiError JNICALL IsClassUnloadingEnabled(const jvmtiEnv* env, > jboolean* enabled, ...) > but according to jvmti specs it should be: > static jvmtiError JNICALL IsClassUnloadingEnabled(const jvmtiEnv* env, ...) > same with ClassUnload(jvmtiEnv* jvmti_env, JNIEnv* jni_env, const char* name, > ...) in tests > for many years that didn't matter but with coming JEP-391 it becomes > important to make it match the spec > https://developer.apple.com/documentation/apple_silicon/addressing_architectural_differences_in_your_macos_code > This commit makes the above mentioned functions to have signature matching > jvmti specification
Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision: Add impl of CSR JDK-8254014 ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/466/files - new: https://git.openjdk.java.net/jdk/pull/466/files/1ef832d2..cd7c4d53 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=466&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=466&range=00-01 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/466.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/466/head:pull/466 PR: https://git.openjdk.java.net/jdk/pull/466