On Wed, 14 Apr 2021 23:11:56 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
> It looks good. I do not see any serviceability related related issues but
> posted some nits.
> Thanks,
> Serguei
Thank you Serguei!
> src/hotspot/share/prims/jvmtiEnv.cpp line 952:
>
>> 950: if (!JvmtiSuspendControl::suspend(java_thread)) {
>> 951: // Either the thread is already suspended or
>> 952: // the thread was in the process of exiting:
>
> Nit: replace this line with: "// it was in process of exiting."
Fixed
> src/hotspot/share/prims/jvmtiEnv.cpp line 993:
>
>> 991: if (!JvmtiSuspendControl::suspend(java_thread)) {
>> 992: // Either the thread is already suspended or
>> 993: // the thread was in the process of exiting:
>
> Nit: replace this line with: "// it was in process of exiting."
Fixed
> src/hotspot/share/prims/jvmtiEnv.cpp line 998:
>
>> 996: continue;
>> 997: }
>> 998: results[i] = JVMTI_ERROR_THREAD_SUSPENDED;
>
> Nit: Remove one extra space after '='.
Fixed
> src/hotspot/share/prims/jvmtiEnv.cpp line 1006:
>
>> 1004: if (!JvmtiSuspendControl::suspend(current)) {
>> 1005: // Either the thread is already suspended or
>> 1006: // the thread was in the process of exiting:
>
> Nit: replace this line with: "// it was in process of exiting."
Fixed
> src/hotspot/share/prims/jvmtiEnv.cpp line 1010:
>
>> 1008: results[self_index] = JVMTI_ERROR_THREAD_NOT_ALIVE;
>> 1009: } else {
>> 1010: results[self_index] = JVMTI_ERROR_THREAD_SUSPENDED;
>
> Nit: Remove one extra space after '='.
Fixed
-------------
PR: https://git.openjdk.java.net/jdk/pull/3191
