On Thu, 15 Apr 2021 22:22:53 GMT, David Holmes <dhol...@openjdk.org> wrote:
> Only nits on the incremental.
>
> Like Dan I need to re-examine the complete set of changes to see if anything
> else sticks out (other than the non-encapsulation of the state changes around
> locking/unlocking when suspended).
>
> Thanks,
> David
Yes please.
Robbin
> src/hotspot/share/prims/jvmtiEnv.cpp line 952:
>
>> 950: if (!JvmtiSuspendControl::suspend(java_thread)) {
>> 951: // Either the thread is already suspended or
>> 952: // it was in process of exiting.
>
> Nit: the previous comment was perfectly correct. It is okay to replace the
> second "the thread" with "it" but it should still read "in _the_ process of
> exiting".
Fixed
> src/hotspot/share/prims/jvmtiEnv.cpp line 993:
>
>> 991: if (!JvmtiSuspendControl::suspend(java_thread)) {
>> 992: // Either the thread is already suspended or
>> 993: // it was in process of exiting.
>
> Ditto - "in the process ..."
Fixed
> src/hotspot/share/prims/jvmtiEnv.cpp line 1006:
>
>> 1004: if (!JvmtiSuspendControl::suspend(current)) {
>> 1005: // Either the thread is already suspended or
>> 1006: // it was in process of exiting.
>
> Ditto - "in the process ..."
Fixed
-------------
PR: https://git.openjdk.java.net/jdk/pull/3191
