On Wed, 14 Apr 2021 16:30:56 GMT, Daniel D. Daugherty <dcu...@openjdk.org>
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed flag undef dep + spelling error
>
> src/hotspot/share/runtime/objectMonitor.cpp line 972:
>
>> 970:
>> 971: current->frame_anchor()->make_walkable(current);
>> 972: OrderAccess::storestore();
>
> Repeating this comment since my original is marked resolved, but I'm not
> seeing
> a new comment here. I originally pointed this out in the resolved
> conversation,
> but that doesn't make the comment show up in the review emails.
>
> Needs a comment explaining what the memory sync is for.
I seem to have fixed 2 of out 3.
> src/hotspot/share/runtime/objectMonitor.cpp line 1559:
>
>> 1557: if (_succ == current) {
>> 1558: _succ = NULL;
>> 1559: OrderAccess::fence();
>
> My original comment is marked "fixed", but I don't see the new comment:
>
> Please add a comment to this line:
> OrderAccess::fence(); // always do a full fence when successor is cleared
I fixed the one at line 982, it was not clear there were two from your comment
:) Fixed
-------------
PR: https://git.openjdk.java.net/jdk/pull/3191
