On Thu, 2 Mar 2023 09:20:23 GMT, Kevin Walls <kev...@openjdk.org> wrote:
> Test update for an occasional failure, which does not reproduce.
>
> The test failure in JDK-8303136 is at line 141 in the updated file here.
> It's the failure where isExceeded is true, but our sampled "used" value is
> not above the threshold. But while the comment says it's refreshing values,
> it does not not refresh "used", so there could have been gc/promotion
> activity which hits the threshold outside of the test's control. Refreshing
> "used" is the addition here.
>
> Separately, the code at line 123 in the new file also claims to refresh the
> values, but it only refreshes the threshold, which we aren't changing. Not
> making it refresh "used" at that point looks correct, so remove the "if (used
> >= threshold)" as we have already checked that at line 116.
test/hotspot/jtreg/vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded001.java
line 126:
> 124: threshold = monitor.getCollectionThreshold(pool);
> 125: usage = monitor.getCollectionUsage(pool);
> 126: if (used >= threshold) {
Although `used` is not updated, `threshold` is. Couldn't removing this extra
check result in new failures?
-------------
PR: https://git.openjdk.org/jdk/pull/12823
