On Thu, 2 Mar 2023 09:20:23 GMT, Kevin Walls <kev...@openjdk.org> wrote:
> Test update for an occasional failure, which does not reproduce. > > The test failure in JDK-8303136 is at line 141 in the updated file here. > It's the failure where isExceeded is true, but our sampled "used" value is > not above the threshold. But while the comment says it's refreshing values, > it does not not refresh "used", so there could have been gc/promotion > activity which hits the threshold outside of the test's control. Refreshing > "used" is the addition here. > > Separately, the code at line 123 in the new file also claims to refresh the > values, but it only refreshes the threshold, which we aren't changing. Not > making it refresh "used" at that point looks correct, so remove the "if (used > >= threshold)" as we have already checked that at line 116. This pull request has now been integrated. Changeset: afda8fbf Author: Kevin Walls <kev...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/afda8fbf0bcea18cbe741e9c693789ebe0c6c4c5 Stats: 12 lines in 1 file changed: 1 ins; 4 del; 7 mod 8303136: MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded005 failed with "isCollectionUsageThresholdExceeded() returned true, while threshold = 1 and used = 0" Reviewed-by: cjplummer, sspitsyn ------------- PR: https://git.openjdk.org/jdk/pull/12823
