On Wed, 6 Dec 2023 05:50:02 GMT, Denghui Dong <dd...@openjdk.org> wrote:
>> Hi, >> >> Could I have a review of this patch? >> >> In the current implementation, HeapDumpBeforeFullGC/AfterFullGC will >> generate dumps for every FGC, increasing the risk of disk full. >> >> This patch introduces a new option 'FullGCHeapDumpLimit' to limit the number >> of dumps triggered by HeapDumpBeforeFullGC/AfterFullGC to enhance >> production-friendliness. >> >> Best, >> Denghui > > Denghui Dong has updated the pull request incrementally with one additional > commit since the last revision: > > change the location of test src/hotspot/share/runtime/globals.hpp line 557: > 555: "Limit the number of heap dumps triggered by " > \ > 556: "HeapDumpBeforeFullGC or HeapDumpAfterFullGC " > \ > 557: "(0 means no limit)" ) > \ nit: should be no space before the last paren. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16976#discussion_r1428625595
