On Sat, 16 Dec 2023 04:36:57 GMT, Denghui Dong <dd...@openjdk.org> wrote:

>> Hi,
>> 
>> Could I have a review of this patch?
>> 
>> In the current implementation, HeapDumpBeforeFullGC/AfterFullGC will 
>> generate dumps for every FGC, increasing the risk of disk full.
>> 
>> This patch introduces a new option 'FullGCHeapDumpLimit' to limit the number 
>> of dumps triggered by HeapDumpBeforeFullGC/AfterFullGC to enhance 
>> production-friendliness.
>> 
>> Best,
>> Denghui
>
> Denghui Dong has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   refine description

Update looks good.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16976#pullrequestreview-1785576985

Reply via email to