On Tue, 4 Jun 2024 11:47:25 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Hello Serguei, that `timeout=240` appears to have been added as part of >> https://bugs.openjdk.org/browse/JDK-6528548 to several of these tests back >> in Java 7 days because the `shell` test which was creating the jar file was >> timing out. The actual test itself, the one which uses the generated jar to >> run the agent, was completing within a second or two. >> >> With the current state of the PR I have run tier3 in our CI and there too >> both these tests complete within a second on all platforms. So I decided not >> to copy over this timeout as part of this change. > > My guess is these tests were timed out when executed with some specific > options like -Xint, -Xcomp or any other that can slow down the execution > (e.g. DeoptimizeALot). I have now updated the PR to use the same timeout that was used for the `shell` test before the changes in this PR. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19495#discussion_r1625919837
