On Tue, 4 Jun 2024 12:31:13 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> My guess is these tests were timed out when executed with some specific >> options like -Xint, -Xcomp or any other that can slow down the execution >> (e.g. DeoptimizeALot). > > I have now updated the PR to use the same timeout that was used for the > `shell` test before the changes in this PR. I think `timeout`s are not needed for the refactored tests. Per JDK-6528548 the shell action has timed out using a network mounted JDK (MakeJAR2.sh run `javac` 3 times and `jar` 1 time). But I don't see big problem here - up to the author to keep or remove them. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19495#discussion_r1626468824
