On Tue, 11 Jun 2024 07:50:23 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Inigo Mediavilla Saiz has updated the pull request with a new target base >> due to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 15 >> additional commits since the last revision: >> >> - Merge remote-tracking branch 'upstream/master' into >> txominpelu_8330846_add_stack_vthreads >> - Include virtual thread name in output >> - Incorporate @tstuefe's remarks >> - Remove dead code >> - Remove extra indentation (leave it for the next PR) >> - Cleanup test >> >> - Stop virtualthread >> - Remove unneeded imports >> - Remove modules that are not needed >> - Fix copyright year >> - Print mounted virtual thread after carrier >> - Add indentation for virtual thread stack >> - Update >> test/hotspot/jtreg/serviceability/dcmd/thread/PrintVirtualThreadTest.java >> >> Co-authored-by: Andrey Turbanov <turban...@gmail.com> >> - ... and 5 more: https://git.openjdk.org/jdk/compare/dc16650d...ba3385a4 > > test/hotspot/jtreg/serviceability/dcmd/thread/PrintVirtualThreadTest.java > line 40: > >> 38: * @run testng PrintVirtualThreadTest >> 39: */ >> 40: public class PrintVirtualThreadTest { > > It might be helpful to put "Mounted" into the test name as this is a test to > check that a mounted virtual thread appears in the Thread.print output, > something like PrintMountedVirtualThread. Good idea, I've done that in b1e61b22ee912343d54dbb70bfba0413439f891b ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19482#discussion_r1634392143
