> There are issues with the test attaching to the debuggee too soon, and the 
> debug agent isn't ready. yet. This test is based on ProcessAttachTest, which 
> does not have this issue. I eventually realized the reason why is because 
> ProcessAttachTest has this little snippet of code, which I had removed from 
> DataDumpTest:
> 
>              // Wait for the process to start
>             InputStream is = p.getInputStream();
>             is.read(); 
> 
> This is waiting for the start of the debug agent's "Listening..." message. 
> I've re-added this to DataDumpTest, and it seems to fix the issue. Tested by 
> running 20 times with `-Xcomp` on all supported platforms with no failures. 
> It used to fail about 2/3 of the time.

Chris Plummer has updated the pull request incrementally with one additional 
commit since the last revision:

  Fix typo in output

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20604/files
  - new: https://git.openjdk.org/jdk/pull/20604/files/bf3b1617..edb4ed35

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20604&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20604&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/20604.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20604/head:pull/20604

PR: https://git.openjdk.org/jdk/pull/20604

Reply via email to