On Fri, 16 Aug 2024 16:31:01 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

>> There are issues with the test attaching to the debuggee too soon, and the 
>> debug agent isn't ready. yet. This test is based on ProcessAttachTest, which 
>> does not have this issue. I eventually realized the reason why is because 
>> ProcessAttachTest has this little snippet of code, which I had removed from 
>> DataDumpTest:
>> 
>>              // Wait for the process to start
>>             InputStream is = p.getInputStream();
>>             is.read(); 
>> 
>> This is waiting for the start of the debug agent's "Listening..." message. 
>> I've re-added this to DataDumpTest, and it seems to fix the issue. Tested by 
>> running 20 times with `-Xcomp` on all supported platforms with no failures. 
>> It used to fail about 2/3 of the time.
>
> Chris Plummer has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix typo in output

Thanks Dan!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20604#issuecomment-2293821068

Reply via email to