On Tue, 15 Oct 2024 23:55:52 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor comment tweak
>
> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp
> line 93:
>
>> 91: LOG("ERROR: FramePop event is for wrong method: expected %s, got
>> %s\n", lastNotifyMethod, name);
>> 92: failed = JNI_TRUE;
>> 93: fatal(jni, "DBG: FramePop event in wrong method\n");
>
> looks like "DBG" is leftover from other test?
Thanks. Removed "DBG: " prefix.
> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp
> line 161:
>
>> 159: if (isMain) {
>> 160: if (seenMain) {
>> 161: return JNI_FALSE; // Only do NotifyFramePop once for main()
>
> `deallocate(jvmti, jni, name);`
Fixed, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1802213563
PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1802214841
