On Wed, 16 Oct 2024 00:49:39 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/NotifyFramePopStressTest.java
>> line 103:
>>
>>> 101: }
>>> 102: }
>>> 103: if (waitCount > 50) {
>>
>> Is 50 is enough here? (like in "Xcomp" mode) the cycle above exits after
>> 1000 iterations.
>
> It was written to fail if the count is over 50, but it will wait up to 1000
> before exiting the loop to provide a bit of debugging info. If it gets to a
> 1000, then the test is probably stuck. If it fail let's say at 75, then maybe
> the test just needs an adjustment to wait for more iterations.
I've changed it from 50 to 100 but this can be not enough for `-Xcomp`.
I've never seen it yet failed with `-Xcomp` though.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1802239003
