On Tue, 22 Oct 2024 17:24:55 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Merging vm folder's InMemoryJavaCompiler into jdk folder's merge
>> InMemoryJavaCompiler so that maintenance is easy.
>>
>> Testing done for
>> Tiers 1,2,3
>> test/hotspot/jtreg tests
>
> test/lib/jdk/test/lib/compiler/InMemoryJavaCompiler.java line 228:
>
>> 226: }
>> 227:
>> 228: public static Map<String, byte[]> compile(Map<String, ? extends
>> CharSequence> inputMap) {
>
> Could the tests that use this 'compile' be easily fixed to use the below
> version of 'compile' so you can delete this too?
Agree, most of tests should be updated to use compile(String className ...)
and remove wrapping the single file into Map.
While there are tests that need this method to compile several source files as
a single batch.
This comments should be added to this method , and it might be renamed to
clearly says that it compile a batch of files.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21641#discussion_r1811182608
