On Tue, 22 Oct 2024 15:52:27 GMT, Ramkumar Sunderbabu <rsunderb...@openjdk.org>
wrote:
> Merging vm folder's InMemoryJavaCompiler into jdk folder's merge
> InMemoryJavaCompiler so that maintenance is easy.
>
> Testing done for
> Tiers 1,2,3
> test/hotspot/jtreg tests
Changes requested by lmesnik (Reviewer).
test/lib/jdk/test/lib/compiler/InMemoryJavaCompiler.java line 173:
> 171:
> 172: // Wraper for class file
> 173: static class ClassFile extends SimpleJavaFileObject {
The original class has
MemoryJavaFileObject
already which could be removed now once we have
ClassFile and SourceFile
test/lib/jdk/test/lib/compiler/InMemoryJavaCompiler.java line 243:
> 241: System.out.println(writer.toString());
> 242: System.out.println("*********** javac output end
> ***********");
> 243: if
> (writer.toString().contains("java.lang.OutOfMemoryError")) {
I don't think we need separate OOME handling. Not sure it ever can happens.
-------------
PR Review: https://git.openjdk.org/jdk/pull/21641#pullrequestreview-2385956062
PR Review Comment: https://git.openjdk.org/jdk/pull/21641#discussion_r1811190699
PR Review Comment: https://git.openjdk.org/jdk/pull/21641#discussion_r1811184213
