On Tue, 19 Nov 2024 00:40:09 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
> The jcmd VM.events max parameter type is changed to INT. > Also,I noted the max <= 0 is ignored, so I updated documentation and set "0" > as a default value. > The jcmd exists if parameter is negative now. > > The `max` is `int` while really it is the unsigned int. However I don't think > it makes sense to change it to `size_t` or `unsigned int` in all places where > 'max' is used. I always struggle seeing the full code path for DCmd arguments, if you no longer parse the STRING to get an int, then where is the parsing now happening? src/hotspot/share/services/diagnosticCommand.hpp line 892: > 890: protected: > 891: DCmdArgument<char*> _log; > 892: DCmdArgument<jlong> _max; Why `jlong` and not `jint`? ------------- PR Review: https://git.openjdk.org/jdk/pull/22224#pullrequestreview-2444425042 PR Review Comment: https://git.openjdk.org/jdk/pull/22224#discussion_r1847736544
