On Tue, 19 Nov 2024 00:40:09 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:

> The  jcmd VM.events max parameter type is changed to INT.
> Also,I noted the max <= 0 is ignored, so I updated documentation and set "0" 
> as a default value.
> The jcmd exists if parameter is negative now.
> 
> The `max` is `int` while really it is the unsigned int. However I don't think 
> it makes sense to change it to `size_t` or `unsigned int` in all places where 
> 'max' is used.

Looks good.
Right, the all integer parsing is signed, and long, and we don't express any 
more detail in the man page or the MBean, it's just "INT" for an integral value.
OK, speaking of man pages... 8-)
(that could be updated here or separately)

-------------

Marked as reviewed by kevinw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22224#pullrequestreview-2444977753

Reply via email to