On Tue, 19 Nov 2024 07:06:15 GMT, David Holmes <dhol...@openjdk.org> wrote:

>> There was an extern trace_class_resolution() function that called this _impl 
>> function that I removed, so renamed this impl function to 
>> trace_class_resolution().
>> It's declared extern in jvm.hp file, and this 'extern' qualifier is added so 
>> it's easy to see that this is used externally.
>
> Sorry but not seeing that. It is declared in `jvm_misc.hpp` but not as 
> `extern`. The original version was not `extern`.

You're right, it has extern linkage but not declared with extern.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22064#discussion_r1848255968

Reply via email to