On Thu, 14 Nov 2024 19:03:18 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
> This change adds a couple of comments, removes some ancient bootstrapping > code, and adds an old test that we call the verifier for redefining a class, > even one in the bootclass path. > > The fix for always verifying redefined classes was actually pushed with > JDK-8341094, where the verifier code respected the parameter > "should_verify_class". By default this parameter follows the -Xverify > setting. For redefinition, this is passed as true. The rest of the fix > removes the special bootstrap loader cases that may have failed early on in > the JDK development with -Xverify:all but now no longer do. If someone tries > to redefine these classes, they should also do the verification on the > redefined bytecodes. > > Tested with tier1-4. This pull request has now been integrated. Changeset: 8f22db23 Author: Coleen Phillimore <cole...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/8f22db23a50fe537d8ef369e92f0d5f9970d98f0 Stats: 141 lines in 4 files changed: 118 ins; 22 del; 1 mod 8330606: Redefinition doesn't but should verify the new klass Reviewed-by: dholmes, jsjolen ------------- PR: https://git.openjdk.org/jdk/pull/22116