On Wed, 20 Nov 2024 03:46:46 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reduce test, fix bug in verifier, move and add comments to
>> is_eligible_for_verification.
>
> src/hotspot/share/oops/method.cpp line 339:
>
>> 337: int Method::validate_bci(int bci) const {
>> 338: // Called from the verifier, and should return -1 if not valid.
>> 339: return ((is_native() && bci == 0) || (!is_native() && 0 <= bci && bci
>> < code_size())) ? bci : -1;
>
> This expansion seems more correct, but it also seems unrelated to the main
> changes.
This expansion was the fix to a bug that I hit while testing the main change.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22116#discussion_r1850227299
