On Wed, 25 Dec 2024 16:40:19 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Restore ACC in comment. > > src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp line 149: > >> 147: // _access_flags must be a 16 bit value. >> 148: assert(sizeof(AccessFlags) == 2, "wrong size"); >> 149: __ lha(R11_scratch1/*access_flags*/, method_(access_flags)); > > Using `lhz` would be more consistent. `lha` uses sign extend instead of zero > extend. Feel free to clean this up if you want. Both instructions should work. I fixed this - it was the only one. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22246#discussion_r1900858739
