On Thu, 2 Jan 2025 23:33:31 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Happy New Year
>
> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 1151:
>
>> 1149: // methods match, be sure modifiers do too
>> 1150: old_flags = k_old_method->access_flags().as_unsigned_short();
>> 1151: new_flags = k_new_method->access_flags().as_unsigned_short();
>
> Nit: I'd suggest to use `as_method_flags()` and `as_class_flags()` at lines
> 1008-1009 to make it consistent with the lines 1043-1044. Good example is
> `jvmtiClassFileReconstituter.cpp`. Also, it would make sense to expend this
> rule to some other files, e.g.: `method.cpp`, `methodHandles.cpp`,
> `jvmtiEnv.cpp`, `jvm.cpp`, `instanceClass.cpp`, `fieldInfo.inline.hpp`,
> `fieldInfo.cpp`
This is a good suggestion. I strengthened the as_{field|method|class}_flags
functions because they should be stored with only their recognized modifiers in
the appropriate place. Retesting.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22246#discussion_r1902091752
