On Thu, 13 Feb 2025 12:30:32 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> DescriptorSupport has a constructor and a method providing creation from,
>> and export to, XML.
>>
>> These are unused in the JDK and have no practical known examples of usage.
>> XML parsing is best done by an independent implementation, not this class.
>
> Kevin Walls has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains eight additional
> commits since the last revision:
>
> - comments
> - Merge remote-tracking branch 'upstream/master' into
> 8347433_DescriptorSupport_deprecate_XML
> - (c)
> - typo
> - Merge remote-tracking branch 'upstream/master' into
> 8347433_DescriptorSupport_deprecate_XML
> - Also XMLParseException
> - RMMB comment update
> - Deprecate XML interchange in DescriptorSupport
Thanks for the comments @dfuch
Added the "can be implemented externally" wording.
I'm adding comments about XMLParseException usage, one for each use, which is
quite verbose BUT temporary, as this is all about planning for imminent removal.
(Looking around at other uses of @SuppressWarnings("removal") I didn't find one
where we spell out in a comment exactly what is for removal that we are
suppressing.)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23038#issuecomment-2656459128
