On Mon, 24 Feb 2025 09:59:15 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> DescriptorSupport has a constructor and a method providing creation from, >> and export to, XML. >> >> These are unused in the JDK and have no practical known examples of usage. >> XML parsing is best done by an independent implementation, not this class. > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 10 additional > commits since the last revision: > > - constructor->method in deprecated tag > - Merge remote-tracking branch 'upstream/master' into > 8347433_DescriptorSupport_deprecate_XML > - comments > - Merge remote-tracking branch 'upstream/master' into > 8347433_DescriptorSupport_deprecate_XML > - (c) > - typo > - Merge remote-tracking branch 'upstream/master' into > 8347433_DescriptorSupport_deprecate_XML > - Also XMLParseException > - RMMB comment update > - Deprecate XML interchange in DescriptorSupport src/java.management/share/classes/javax/management/modelmbean/DescriptorSupport.java line 978: > 976: * thrown. > 977: * @deprecated This method exists for historical reasons. If > 978: * reading from XML is required, it should be implemented externally. Technically here it should be `writing to XML` - I don't think changing that would require re-submitting the CSR - but maybe @jddarcy could confirm? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23038#discussion_r1977207451