On Thu, 13 Feb 2025 19:27:19 GMT, Chris Plummer <[email protected]> wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> rename SA argument
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CodeCache.java line
> 97:
>
>> 95: // cbAddr - address of a code blob
>> 96: // cbPC - address inside of a code blob
>> 97: public CodeBlob createCodeBlobWrapper(Address cbAddr, Address cbPC) {
>
> Can you change findBlobUnsafe() above also? That's where the naming problem
> originated.
After some thoughts I think `PC` is not usually used by us.
I renamed `cbAddr` to `cbStart` and `cbPC`/`start` to `addr` in this whole file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23533#discussion_r1956664966
