On Thu, 13 Feb 2025 17:14:59 GMT, Vladimir Kozlov <k...@openjdk.org> wrote:

>> Remove virtual methods from CodeBlob and nmethod to simplify 
>> saving/restoring in Leyden AOT cache. It avoids the need to patch hidden 
>> VPTR pointer to class's virtual table.
>> 
>> Added C++ static asserts to make sure no virtual methods are added in a 
>> future.
>> 
>> Fixed/cleaned SA code which process CodeBlob and its subclasses. Use 
>> `CodeBlob::_kind` field value to determine the type of blob.
>> 
>> Tested tier1-5, hs-tier6-rt (for JFR testing), stress, xcomp
>
> Vladimir Kozlov has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   rename SA argument

I addressed most @xmas92 and @dean-long comments and working on avoid `_v` 
suffix

Thank you, Dean, for review.

-------------

PR Review: https://git.openjdk.org/jdk/pull/23533#pullrequestreview-2618707275
PR Comment: https://git.openjdk.org/jdk/pull/23533#issuecomment-2660443983

Reply via email to