On Thu, 20 Feb 2025 07:11:19 GMT, Calvin Cheung <[email protected]> wrote:
>> I don't see anything there that does a vm_exit if something has gone wrong.
>> ??
>
> How about adding the vm_exit in
> `ClassLoaderDataShared::ensure_module_entry_table_exist()` instead of assert?
>
>
> void ClassLoaderDataShared::ensure_module_entry_table_exist(oop class_loader)
> {
> Handle h_loader(JavaThread::current(), class_loader);
> ModuleEntryTable* met = Modules::get_module_entry_table(h_loader);
> if (met == nullptr) {
>
> vm_exit_during_initialization("ClassLoaderDataShared::ensure_module_entry_table_exist()
> failed unexpectedly");
> }
> }
I can't answer that. As a refactoring I expect to see the current behaviour
preserved.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23476#discussion_r1962992658
