On Sun, 23 Feb 2025 23:52:59 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> rename classes and add vm_exit_during_initialization call
>
> src/hotspot/share/cds/aotClassLocation.cpp line 53:
>
>> 51: const AOTClassLocationConfig* AOTClassLocationConfig::_runtime_instance
>> = nullptr;
>> 52:
>> 53: // A ClassLocationStream represents a list of code sources, which can be
>> iterated using
>
> Suggestion:
>
> // A ClassLocationStream represents a list of code locations, which can be
> iterated using
Fixed
> src/hotspot/share/cds/aotClassLocation.cpp line 133:
>
>> 131: };
>> 132:
>> 133: // AllClassLocationStreams is used to iterate over all the code sources
>> that
>
> Suggestion:
>
> // AllClassLocationStreams is used to iterate over all the code locations that
Fixed
> src/hotspot/share/cds/aotClassLocation.hpp line 122:
>
>> 120: // AOTClassLocations (subjected to AOTClassLocationConfig::validate()).
>> 121: //
>> 122: // In general, validation is performed on the AOTClassLocations to
>> ensure the code sources used
>
> Suggestion:
>
> // In general, validation is performed on the AOTClassLocations to ensure the
> code locations used
Fixed
> src/hotspot/share/classfile/classLoaderDataShared.cpp line 157:
>
>> 155: }
>> 156:
>> 157: void ClassLoaderDataShared::ensure_module_entry_table_exist(oop
>> class_loader) {
>
> Suggestion:
>
> void ClassLoaderDataShared::ensure_module_entry_table_exists(oop
> class_loader) {
>
> Tables exist, but a single table exists.
Fixed
> src/hotspot/share/classfile/classLoaderDataShared.hpp line 37:
>
>> 35: class ClassLoaderDataShared : AllStatic {
>> 36: static bool _full_module_graph_loaded;
>> 37: static void ensure_module_entry_table_exist(oop class_loader);
>
> Suggestion:
>
> static void ensure_module_entry_table_exists(oop class_loader);
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23476#discussion_r1968212961
PR Review Comment: https://git.openjdk.org/jdk/pull/23476#discussion_r1968213029
PR Review Comment: https://git.openjdk.org/jdk/pull/23476#discussion_r1968212846
PR Review Comment: https://git.openjdk.org/jdk/pull/23476#discussion_r1968213106
PR Review Comment: https://git.openjdk.org/jdk/pull/23476#discussion_r1968213193
