On Mon, 24 Feb 2025 11:40:03 GMT, Kevin Walls <kev...@openjdk.org> wrote:
> Trivial removal of confusing "Tonga" references in comments within a few JMX
> tests.
Changes requested by lmesnik (Reviewer).
test/jdk/javax/management/MBeanServer/ExceptionTest.java line 227:
> 225: * Reproduces the original parsing and collection of test
> parameters
> 226: * from the DTonga JMX test suite.
> 227: *
There are few similar methods
static Map<String, Object> parseParameters(String args[])
in different Utils classes.
Have you considered the removal of duplication code?
Also, the comment like
" Reproduces the original parsing and collection of test parameters from legacy
test suite"
might explain why this logic is needed. But it is up to you.
-------------
PR Review: https://git.openjdk.org/jdk/pull/23747#pullrequestreview-2638415485
PR Review Comment: https://git.openjdk.org/jdk/pull/23747#discussion_r1968403429
