On Mon, 24 Feb 2025 21:34:41 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> Thanks - >> For the paseParameters(arg) method, I think if I remove the reference to the >> mysterious legacy test suite, there is nothing left in that line worth >> saying. >> >> The comment goes on to say "Collects passed args and returns them in a >> map..etc..." which seems worthwhile. >> >> There probably is much further tidyup that we can do here, yes maybe the >> methods are the same, and maybe so may "Utils" classes is not great. But I >> just wanted to remove this one point of confusion today! > > The link to legacy is a just good explanation why this method is realized in > such way. Like note, "There is might be no logic in this method, just legacy." That's a bit harsh, I wasn't going to say there was no logic to this! 8-) Code this old and quirky (and duplicated...) is kind of legacy by definition. 8-) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23747#discussion_r1968461046
