On Wed, 26 Feb 2025 12:33:14 GMT, Roberto Castañeda Lozano
<rcastaned...@openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with five
>> additional commits since the last revision:
>>
>> - feedback ashu
>> - feedback roberto
>> - final-statistics-switch
>> - performance fix
>> - remove test code
>
> src/hotspot/share/compiler/compilationMemoryStatistic.cpp line 306:
>
>> 304: if (_comp_type == compiler_c2) {
>> 305: // Update C2 node count
>> 306: // Careful, Compile::current() may be NULL in a short time window
>> when Compile itself
>
> The recently added `sources/TestNoNULL.java` test fails due to this
> occurrence of `NULL`.
> Suggestion:
>
> // Careful, Compile::current() may be null in a short time window when
> Compile itself
Thanks. We should add those to GHAs.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23530#discussion_r1976320472
