On Thu, 27 Feb 2025 10:11:37 GMT, Roberto Castañeda Lozano <rcastaned...@openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - feedback ashu >> - feedback roberto >> - final-statistics-switch >> - performance fix >> - remove test code > > src/hotspot/share/runtime/globals.hpp line 1402: > >> 1400: "Print metaspace statistics upon VM exit.") >> \ >> 1401: >> \ >> 1402: product(bool, PrintCompilerMemoryStatisticsAtExit, false, >> DIAGNOSTIC, \ > > Would it be possible to add a test for this new flag, perhaps by extending > the existing test logic in `CompileCommandPrintMemStat`? The test is already there - we test the final print output in CompileCommandPrintMemStat.java. I will change the logic however and only print the final output if `PrintCompilerMemoryStatisticsAtExit` is given (before, it was also printed, and tested as part of, CompilerCommand memstat). Then I will explicitly pass this flag in the test. That should be good enough. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23530#discussion_r1976555741
